ren1986 / transmission-remote-dotnet

Automatically exported from code.google.com/p/transmission-remote-dotnet
GNU General Public License v3.0
0 stars 0 forks source link

When sorting torrents by (highest) ratio, relegate torrents with no uploaded data to bottom of list #396

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
While using transmission-remote-dotnet 3.24, sorting by ratio provides 
unexpected behaviour.

Currently, when sorting torrents by ratio so the highest ratio ranks on top, 
torrents with no uploaded data show a ratio of "infinite" and ranks above any 
other torrent. It makes sense (to me at least) to show these torrents at the 
bottom of the list.

Original issue reported on code.google.com by upp...@gmail.com on 26 May 2011 at 8:19

GoogleCodeExporter commented 8 years ago
I'm in on this too. It more than makes sense, mathematically the ratio is zero 
when you haven't uploaded anything, not infinite.
The ratio is (amount of uploaded data)/(amount of downloaded data), so it tends 
to infinity only if the downloaded data tends to zero. If the uploaded data is 
zero instead, as is the case here, the ratio too is zero.

Original comment by fuzzee...@gmail.com on 15 Jun 2011 at 10:11

GoogleCodeExporter commented 8 years ago
Definitely feel this should be "fixed". Maybe we should change it to defect. 
When uploaded=0B, the ratio = 0 not infinity.

Original comment by valentijnscholten on 15 Aug 2011 at 10:24

GoogleCodeExporter commented 8 years ago
Yes it's definitely a defect. Is it possible to change it? It's the only big 
bug I've found actually.

Original comment by fuzzee...@gmail.com on 15 Aug 2011 at 11:10

GoogleCodeExporter commented 8 years ago
Fixed by r760.

Original comment by elso.and...@gmail.com on 12 Oct 2011 at 9:41