ren1986 / transmission-remote-dotnet

Automatically exported from code.google.com/p/transmission-remote-dotnet
GNU General Public License v3.0
0 stars 0 forks source link

Client error message for 403 (blacklisted IP) is unhelpful #397

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Add client's IP to blacklist, or fail to add client's IP to whitelist
2. Attempt to connect to server

What is the expected output? What do you see instead?
I'd hope to see a useful error message. Instead, the client's error is "The 
remote server returned an error: (403) Forbidden." 

What version of the products are you using?
OS: Win7 service pack 1
Transmission: 2.13 (build 11501)
Remote: 3.24 (rev 0)

The client error isn't that useful, although it's a start. I had to crack open 
Wireshark to figure out what the problem was, and the user shouldn't have to do 
that. The text returned in the HTTP response from the server is much more 
detailed:

"HTTP/1.1 403 Forbidden
...
<h1>403: Forbidden</h1><p>Unauthorized IP Address.</p><p>Either disable the IP 
address whitelist or add your address to it.</p><p>If you're editing 
settings.json, see the 'rpc-whitelist' and 'rpc-whitelist-enabled' 
entries.</p><p>If you're still using ACLs, use a whitelist instead.  See the 
transmission-daemon manpage for details.</p>"

This clearly states the problem, and offers a suggestion for how to fix it; a 
very good error message. The Transmission client should include this text in 
its own error message.

Original issue reported on code.google.com by Symmetri...@gmail.com on 26 Jun 2011 at 7:24

GoogleCodeExporter commented 8 years ago
Fixed: r766

Original comment by elso.and...@gmail.com on 12 Oct 2011 at 9:12