search

renaesop / node-pdfium

Apache License 2.0
11 stars 5 forks source link

Support latest electron? #4

Closed sontek closed 5 years ago

sontek commented 5 years ago

On electron v7 I'm getting this:

Do you know what would cause it?

    sonte@DESKTOP-8EN5N6I C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium
    $ if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
    Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
      Copying C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\x64/lib/pdfium.dll.lib to C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium/build/Release\pdfium.dll.lib
              1 file(s) copied.
      Copying C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\x64/bin/pdfium.dll to C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium/build/Release\pdfium.dll
              1 file(s) copied.
      pdfium_option.cc
      printer_win.cc
      pdfium_imp.cc
      pdfium.cc
      win_delay_load_hook.cc
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8513): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium_option.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium_option.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8522): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium_option.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium_option.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8513): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium_imp.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium_imp.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8522): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium_imp.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium_imp.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8513): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8522): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\pdfium.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8513): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\printer_win.cc)c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\pdfium.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]

      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\printer_win.cc)
    c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(8522): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\printer_win.cc) [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
      c:\users\sonte\.electron-gyp\7.1.1\include\node\v8.h(6918): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\printer_win.cc)
    c:\users\sonte\documents\github\eventray_onsite\node_modules\node-pdfium\src\pdfium.cc(102): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
    c:\users\sonte\documents\github\eventray_onsite\node_modules\node-pdfium\src\pdfium.cc(105): warning C4101: 'e': unreferenced local variable [C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\pdfium.vcxproj]
         Creating library C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\Release\pdfium.lib and object C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\Release\pdfium.exp
      Generating code
      All 1140 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
      Finished generating code
      pdfium.vcxproj -> C:\Users\sonte\Documents\GitHub\eventray_onsite\node_modules\node-pdfium\build\Release\\pdfium.node
    Done in 8.08s.
sontek commented 5 years ago

It does seem to work, just has all those warnings