search

renalreg / ukrr_models

SQL Alchemy models for the UKRR Database. Also exports to RDA.
MIT License
0 stars 0 forks source link

moved out two function to utils #6

Closed andyatterton closed 1 year ago

andyatterton commented 1 year ago

I haven't tested this or taking any real care over it. Phil, could you test it and make sure that I haven't broken whatever it is being used for. I assume you are familiar as yours was the last commit. Looking at it, you did all the hard work of lifting it out of the class but didn't get round to moving it somewhere else. Might be worth putting them into a different repo and just keeping the models as models.

philmain28 commented 1 year ago

@andyatterton I have moved your changes to the other pull request

philmain28 commented 1 year ago

@George-D-S Would this repo: https://github.com/renalreg/ukrr_rda_extract be a better home for the stuff being moved over to utils?

George-D-S commented 1 year ago

Yeah that seems a good idea.