search

renanxcortes / springerQuarantineBooksR

Download all books made available by Springer during the COVID-19 quarantine!
128 stars 41 forks source link

commas and spaces in directory and file names #34

Open rlebron-bioinfo opened 4 years ago

rlebron-bioinfo commented 4 years ago

Commas, spaces and some other non-alphanumeric characters are problematic. Please correct the directory and file names. Thank you very much.

renanxcortes commented 4 years ago

Hi @rlebron-bioinfo , could you share an example of book/directory that was problematic on your side? And what do you mean by "problematic"? For example, the book Plant Physiology, Development and Metabolism is downloading just fine.

leabarteam commented 4 years ago

Hi, First, thanks for your code, however, I have a problem when I want to run it, here is the error message I get and it seems related to this issue.

springerQuarantineBooksR::download_springer_book_files(destination_folder` = "Springer_quarantine_books",lan = "eng",filetype = "both")

Downloading title latest editions. Processing... Fundamentals of Power Electronics (1 out of 376) Error in str_replace_all(book_spec_title, "/", "-") : could not find function "str_replace_all"

Thank you so much

renanxcortes commented 4 years ago

Hi, First, thanks for your code, however, I have a problem when I want to run it, here is the error message I get and it seems related to this issue.

springerQuarantineBooksR::download_springer_book_files(destination_folder` = "Springer_quarantine_books",lan = "eng",filetype = "both")

Downloading title latest editions. Processing... Fundamentals of Power Electronics (1 out of 376) Error in str_replace_all(book_spec_title, "/", "-") : could not find function "str_replace_all"

Thank you so much

Could you try installing and loading stringr package.

Also, I recently fix this behavior with https://github.com/renanxcortes/springerQuarantineBooksR/pull/39. Therefore, if you re-install springerQuarantineBooksR this should also be fixed.