search

renato-bohler / redux-form-input-masks

Input masking with redux-form made easy
https://bohler.dev/redux-form-input-masks/
MIT License
138 stars 10 forks source link

fix(CreateNumberMask.js): allow full select delete #44

Closed scottmcpherson closed 6 years ago

scottmcpherson commented 6 years ago

@renato-bohler This fixes #43. I was trying to make sense of the failing test - the one that was removed, but it didn't really seem to be a valid test. Not sure why the prefix or suffix would change when changing a value. It's possible I'm overlooking something though.

renato-bother commented 6 years ago
Warnings
:warning: Please assign someone to merge this PR, and optionally include people who should review.

Generated by :no_entry_sign: dangerJS

codecov-io commented 6 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         265    265           
=====================================
  Hits          265    265
Impacted Files Coverage Δ
src/createNumberMask.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31b214d...8aa92c9. Read the comment docs.

renato-bohler commented 6 years ago

:tada: This PR is included in version 1.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: