search

renato-rg / electron-react-webpack

Electron + React 16 + Webpack 4 template with ES6, JSX and hot reloading.
230 stars 52 forks source link

electron-renderer #10

Closed holtwick closed 6 years ago

holtwick commented 6 years ago

I think this should be electron-renderer?

https://github.com/pastahito/electron-react-webpack/blob/0ca6107cb2443417c5ad9c681efa34b17b08ec82/webpack.config.js#L7

renato-rg commented 6 years ago

@holtwick I'm not sure

holtwick commented 6 years ago

electron-main is node.js and electron-renderer the Chrome JS engine. Since the code goes into the window it is Chrome-land and therefore I would vote for the later :)

holtwick commented 6 years ago

Also see for comparison https://github.com/chentsulin/electron-react-boilerplate/blob/master/webpack.config.renderer.dev.js

And https://webpack.js.org/concepts/targets/

Anyway, shouldn't make a big difference.