search

renato-rg / electron-react-webpack

Electron + React 16 + Webpack 4 template with ES6, JSX and hot reloading.
231 stars 52 forks source link

semantic-ui-react support #5

Open lalitmee opened 6 years ago

lalitmee commented 6 years ago

I would like to tell you that this webpack is having some problems in creating a bundle for semantic-ui-react and semantic-ui-css. I solved it on my system by using this repo. I would like to create a pull request for that support. May I? :innocent:

renato-rg commented 6 years ago

@lalitmee Sure, feel free to submit a PR, it's a public repo after all. 🐈

xerdink commented 6 years ago

@lalitmee semantic-ui-css has font imports, therefore in webpack.config.js you need to enable file-loader for all type of fonts like this:

            {
                test: /\.(ttf|eot|woff|woff2)$/,
                loader: "file-loader",
                options: {
                  name: "fonts/[name].[ext]",
                },
            },
lalitmee commented 6 years ago

Hey @orhaneee , thanx for rplying but I would like to tell you that yeah you are right and I have solved this issue earlier. I have created a pull request in this repo for that support.. :smiley:

xerdink commented 6 years ago

@lalitmee hahaha, sorry I did not read it carefully.. I thought it was your issue. 👍