renatoathaydes / Automaton

Simple framework which allows the testing of Swing and JavaFX2 applications.
Apache License 2.0
100 stars 21 forks source link

text selector on FXer #31

Closed matanbanin closed 9 years ago

matanbanin commented 9 years ago

Hi, as the last one who opened an issue we also enjoy your framework very much, and use it to test our apps. Respect for the awsome work.

But when i try to use the fxer.getAt("text:someText") selector i get an exception of MissingMethodException in TableHeaderRow.getText()

Thank you! and please continue on the good work.

renatoathaydes commented 9 years ago

Thank you for the compliments!! I appreciate it.

Please post the whole stack-trace if possible. That makes is much easier to fix the issue.

matanbanin commented 9 years ago

we work on separate lan and it is huge bureaucracy to bring it into here... can i give you a specific information from it?

renatoathaydes commented 9 years ago

What's the first (from top to bottom) class and line from Automaton code which shows up in the stack trace?

For example:

MyException at:
a.b.C:10
com.athaydes.automaton.Automaton:54
com.athaydes.automaton.Automaton:23
c.d.E:22
e.f.G:33

I just need to know Automaton:54 from this stack-trace.

If you have any caused by OtherException in it, then I would be interested in OtherException instead.

matanbanin commented 9 years ago

sorry for the huge delay! a long vacation in israel...

image

renatoathaydes commented 9 years ago

You seem to be using an older version of Automaton. I cannot find out why this is happening in your tests, but please try to upgrade to the latest version of Automaton (1.2.3 as of today)... The code does check if the method exists before calling it... I would be really surprised if that still happened after you upgraded.

renatoathaydes commented 9 years ago

Ok, I wrote a test to select the header of a JavaFX Table, which is what you're trying to do here, and got the same error... Someone thought it was a good idea to have a getText method in this class which requires an argument! I didn't expect that to happen (getText is supposed to be a simple getter)!!

Will fix for the next release, which is maybe a few days ahead...

renatoathaydes commented 9 years ago

Problem fixed. Will release the fix soon with version 1.2.4. There's a PR in progress which I want to merge before releasing... shouldn't take more than a couple of days. You can try this fix by checking out the code yourself, if it's important.

matanbanin commented 9 years ago

Awosome :) :+1: Thank you very much! Do you have an assessment of when it will be released?

renatoathaydes commented 9 years ago

I should make a release in one week or two... I have been splitting out part of Automaton into a new library... It's done already, but I need to write new docs, test some more, update documentation etc.

renatoathaydes commented 9 years ago

Hello @matanbanin I've released version 1.3.0-beta (no 1.2.4 as too many things were changed). Please try it out.