renatoathaydes / osgi-run

Osgi-Run - A Gradle plugin to make the development of modular applications using OSGi completely painless
Apache License 2.0
54 stars 13 forks source link

multiline javaArgs breaks run.sh script #43

Closed thugcee closed 8 years ago

thugcee commented 8 years ago

example build.gradle fragment:

runOsgi {
    [...]
    javaArgs = '''
        -Djersey=true
        -Dosgi.clean=true 
    ''''

works for ./gradlew runOsgi but run.sh script looks like this:

[...]
"$JAVA"
                -Djersey=true
                -Dosgi.clean=true 
         -jar org.apache.felix.main-5.4.0.jar  "$@"

There should be '\' at line ends.

renatoathaydes commented 8 years ago

Why don't you do this:

runOsgi {
    [...]
    javaArgs = '''\
        -Djersey=true\
        -Dosgi.clean=true \
    ''''
}
thugcee commented 8 years ago

I do :) but every time I edit and copy those properties between different launch environments, I have to run macro to add or strip the '\'.

renatoathaydes commented 8 years ago

Ok... well, I guess it never makes sense to have new-lines in javaArgs... so we can actually fix that.

thugcee commented 8 years ago

Thx . and BTW great plugin :)