search

renatoathaydes / spock-reports

This project creates a global extension to Spock to create test reports.
Apache License 2.0
273 stars 68 forks source link

Fix #244 all info are grouped into 1st itertaion when no Unroll #247

Closed Frankie0701 closed 1 year ago

Frankie0701 commented 1 year ago

Should check iteration.estimatedNumIterations to know if there is multiple iterations without Unroll, value is -1 under this case

Frankie0701 commented 1 year ago

Hi @renatoathaydes, Could you give me some feedback on this PR when you are not too busy? many thanks

renatoathaydes commented 1 year ago

Hi @renatoathaydes, Could you give me some feedback on this PR when you are not too busy? many thanks

Have you seen my comments above?

Frankie0701 commented 1 year ago

Have you seen my comments above?

I don't seem to see any comments from you

renatoathaydes commented 1 year ago

Oh embarrassing. The comments were "pending", but I didn't know that meant you could not see them :(

Sorry, I had reviewed it long ago, and then forgot about it... please have a look at my comments.

Frankie0701 commented 1 year ago

Oh embarrassing. The comments were "pending", but I didn't know that meant you could not see them :(

Sorry, I had reviewed it long ago, and then forgot about it... please have a look at my comments.

it's fine, I thought you were busy, and I was also taking vacation in the past weeks, good that I asked, thanks for review