search

renatomarinho / laravel-page-speed

Package to optimize your site automatically which results in a 35%+ optimization
MIT License
2.42k stars 279 forks source link

Added Laravel 6 & 7 Support #120

Closed nasrulhazim closed 4 years ago

nasrulhazim commented 4 years ago

I have added Laravel 6 & 7 Support, together with updating unit tests :

  1. Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

  2. Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

The only unit test not update is about the exception:

The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageRegExp() instead.

joaorobertopb commented 4 years ago

Hi @nasrulhazim thanks for contribution!

But these changes have already been submitted and are under review 😅

Please see https://github.com/renatomarinho/laravel-page-speed/pull/111 and https://github.com/renatomarinho/laravel-page-speed/pull/119

nasrulhazim commented 4 years ago

119

I see. hoping to merge the PR soon. Cause my apps are waiting for the Laravel 7 support.