renatomarinho / laravel-page-speed

Package to optimize your site automatically which results in a 35%+ optimization
MIT License
2.4k stars 276 forks source link

Added PHP 8 Support from 2.x branch #140

Closed lakuapik closed 3 years ago

lakuapik commented 3 years ago

Description

Basically just a copy of this https://github.com/renatomarinho/laravel-page-speed/pull/139/commits/022f1a867cbfdf8c7774293552eae8a129e61ae0 and use 2.x branch instead of master branch.

Motivation and context

Please support PHP 8, we need this.

How has this been tested?

Not tested.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

lakuapik commented 3 years ago

Context: https://github.com/renatomarinho/laravel-page-speed/pull/139#issuecomment-738765392

lucasMesquitaBorges commented 3 years ago

Thank you @lakuapik for you contribution!

mennorenkens commented 3 years ago

@lucasMesquitaBorges Any idea when the 2.0.0 version including PHP 8.0 support will be released?

joaorobertopb commented 3 years ago

Thanks!