renatomarinho / laravel-page-speed

Package to optimize your site automatically which results in a 35%+ optimization
MIT License
2.4k stars 275 forks source link

Version 2.0 #143

Closed joaorobertopb closed 3 years ago

joaorobertopb commented 3 years ago

Description

This big PR will:

Motivation and context

Why is this change required? What problem does it solve?

It fixes: #30 #46 #55 #57 #77 #82 #107 #108 #122 #129 #136 #141

The CollapseWriteSpace::class filter was producing a bug when the HTML contains inline JS comments.... All JS code after the inline comment was also commented!

How has this been tested?

Refactoring and improve test coverage.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!