search

renatomarinho / laravel-page-speed

Package to optimize your site automatically which results in a 35%+ optimization
MIT License
2.4k stars 275 forks source link

Laravel 9.0 Compatibility #162

Closed gofish543 closed 2 years ago

gofish543 commented 2 years ago

Description

This PR brings laravel-page-speed up to Laravel 9.0 Compatibility with issue #161

swapnilsarwe commented 2 years ago

any chances this getting merged before Laravel 9 release?

gofish543 commented 2 years ago

@renatomarinho Can we please get this merged or looked at?

davidldear commented 2 years ago

Bumping so we can hopefully go to 9.0 as well.

padre commented 2 years ago

@renatomarinho will this package be updated for Laravel 9 support?

Thanks!

BramImhof commented 2 years ago

@renatomarinho could you please merge this? :)

swapnilsarwe commented 2 years ago

Hello Everyone,

@gofish543 has already made effort to create a PR for the Laravel 9 support, many thanks to him.

Till the time @renatomarinho gets time to check this and merge, I would suggest people to use the @gofish543 fork in the meanwhile, rather than posting & pushing @renatomarinho to get this merged. Let him take his time from his schedule and get it done peacefully.

If you need help how to get that done.

Following is the way: In composer.json

To do so, temporarily add @gofish543 fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/gofish543/laravel-page-speed.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "renatomarinho/laravel-page-speed": "dev-laravel9.0",
    }
}

Finally, run: composer update

joaorobertopb commented 2 years ago

Thanks @gofish543 !