Updated the composer json because when you try to install the pacakge…

SaadRizwanKhan commented 1 year ago

… with composer in laravel 10 it does not work and gives compatibility issue errors, I have fixed it by updating the composer.json file for the project.

Description

When I tried to install this package in my new Laravel 10 project I faced an issue that the package was not compatible. So I went to the repo and took a look at the issues, someone tried to fix it but did not update properly and that code was merged in the master branch, but it is not working. So I created this pull request and fixed the issue.

Motivation and context

Mentioned above 😄

Why is this change required? What problem does it solve? This change is required so that the package is installable via composer properly and devs don't have to install this package manually. This fixes issue #172 which was merged.

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[] I have added tests to cover my changes.
[] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

usernotnull commented 1 year ago

Any updates on this? @renatomarinho

padre commented 1 year ago

@renatomarinho can you merge this, please?

SaadRizwanKhan commented 1 year ago

@renatomarinho kindly review. 😄

aixizu commented 1 year ago

my question is, why did this small mistake get through

SaadRizwanKhan commented 1 year ago

Can you merge these changes as other people face the same issue, @renatomarinho ? 😄

Brezinben commented 1 year ago

up ? @renatomarinho

renatomarinho / laravel-page-speed