renatomarinho / laravel-page-speed

Package to optimize your site automatically which results in a 35%+ optimization
MIT License
2.42k stars 279 forks source link

Fixed Auto-Discover #91

Closed stakahashi closed 5 years ago

stakahashi commented 5 years ago

Description

Auto-Discover was fixed. In addition, we set a setting value that does not load unnecessary middleware.

Motivation and context

fixed #88

How has this been tested?

composer test

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

joaorobertopb commented 5 years ago

Thanks for contribution! :smile:

@stakahashi This PR requires a change in documentation. Please, update the Readme file.

Great work!

joaorobertopb commented 5 years ago

Note: Autodiscover is currently working! But, the middlewares should be registered in "Kernel.php" manually. :sweat_smile:

This PR will avoid the manual registration of middlewares!

stakahashi commented 5 years ago

@joaorobertopb README.md updated.

stakahashi commented 5 years ago

@joaorobertopb I understand. This PR is closed.