renatorib / react-sizes

:left_right_arrow: Hoc to easily map window sizes to props.
722 stars 36 forks source link

Static properties should be copied over #31

Open such opened 6 years ago

such commented 6 years ago

Hey,

Thanks a lot for this library! It appears that you do not copy static methods as described here: https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over It seems the convention is that all HOC should do that. The behaviour is somewhat unexpected otherwise. Are you planning on adding it to the library?

In the meantime, I'm using this workaround:

const WithHoc = compose(
  withRouter,
  withSizes(mapSizesToProps),
  withStyles(styles)
)(WrappedComponent);

hoistNonReactStatic(WithHoc, WrappedComponent);

export default WithHoc;

Thanks!