renatorib / react-sizes

:left_right_arrow: Hoc to easily map window sizes to props.
722 stars 36 forks source link

feat: add useDocumentElement option #54

Open johngeorgewright opened 4 years ago

johngeorgewright commented 4 years ago

I am using other libraries which use an alternative way in finding the window size (document width) (document.documentElement.clientWidth). Which, unlike window.innerWidth, doesn't add the width of the body's scroll bar to it's final value. The difference in pixels will differ from OS, browser & any additional UI enhancements, and trying to use react-sizes with these libraries can be troublesome.

Below is an example of how chrome will differ, between these 2 values, in windows 10.

react-resizes-document

It would be nice if either react-sizes used document width too, or at least had the ability to do so. This pull request adds a configuration option to use the document width instead.

There are a few changes in this pull request added by prettier, which I did not add myself (just incase you thought I was being unhelpfully pedantic).