search

renatosilva / pidgin-windev

Pidgin Windows Development Setup.
Other
10 stars 12 forks source link

Update pidgin-windev for 2.12.0 and security #1

Open genodeftest opened 7 years ago

shiitake commented 6 years ago

I had some issues with running this script in Cygwin

$ ./pidgin-windev.sh pidgin-devel
./pidgin-windev.sh: line 2: $'\r': command not found
./pidgin-windev.sh: line 7: $'\r': command not found

It looks like this is related to some of issues with the line endings. It can be resolved by running dos2unix or by running sed -i 's/\r$//' pidgin-windev.sh (which is what I had to do since I didn't have dos2unix installed)

genodeftest commented 6 years ago

@shiitake : I cannot reproduce your issue on Linux. After and running dos2unix or the sed command you provided above, there are no changes for me to commit to git, so I'm unable to fix this issue. Anyway, since my changes do not touch either lines, I think you should open a new issue. It looks like the git config is wrong. As far as I remember, there are some options to fix line endings in git. You might want to consult the manual. I don't know whether those changes are specific to your git config (i.e. global git config) or this repo git config.

SvenLudwig202 commented 6 years ago

I can confirm: no problems using genodeftest's patch on current cygwin (as of today)

shiitake commented 6 years ago

@genodeftest thanks for the quick reply. sorry for invading your pull request. Since it appears that this repo hasn't been touched in a few years (except for your PR) I figured this might be the quickest way to grab someone's attention.

genodeftest commented 6 years ago

@shiitake : No problem and thanks for testing!