search

renaudbedard / fez-1.12-issues

A public repository for FEZ 1.12 testers to log issues
9 stars 0 forks source link

The main window doesn't have an icon #120

Closed vrubleg closed 8 years ago

vrubleg commented 8 years ago

It would look nicer with an icon of the fez.exe. http://veg.by/z/2016-07-22-16-28-19-b6bd137f.png

flibitijibibo commented 8 years ago

Renaud will just need to add a FEZ.bmp to the game folder, I've got that available so we'll throw it in the next update.

vrubleg commented 8 years ago

BTW, fez.exe itself also lost its icon. v1.11 has an icon.

flibitijibibo commented 8 years ago

Checked up on this in the csproj, the Game.ico is definitely referenced... maybe an outdated thumbs.db or something? I'm just reading a bunch of XML files though, maybe Renaud has a better idea of what's up.

renaudbedard commented 8 years ago

I'll take a look, that part is on me!

vrubleg commented 8 years ago

It seems that I was wrong about the icon in the resources of the fez.exe, sorry. But the main window doesn't have an icon, so the main issue is right.

renaudbedard commented 8 years ago

Window icon, dock icon and file icon confirmed working on my setup. :)

vrubleg commented 8 years ago

That's a little bit strange to load an icon for the window from the external 256×256 bmp file while the same icon is available in the exe resources, but at least it works now, thanks.

vrubleg commented 8 years ago

BTW, I had created this patch for SDL: https://bugzilla.libsdl.org/show_bug.cgi?id=3405 If this patch will be accepted, SDL will use current icon from the resources as a default window icon (on Windows).

vrubleg commented 8 years ago

The patch is accepted: https://hg.libsdl.org/SDL/rev/5c06c3aaca68 So, if you will use the latest revision of the SDL, you can remove fez.png. As the result the first icon from the fez.exe will be used automatically.

vrubleg commented 7 years ago

https://libsdl.org/download-2.0.php

SDL v2.0.5 is released, so you may just use this version of the SDL, and it will use the default icon from the resources. The fez.bmp will not be needed.