Hamburger toggle misbehaviour

[tuanna-hsp]

The toggle does not finish animation or not doing animation at all (when i build release with minify enable). It happened when i build project on some PC but not some others.

[tuanna-hsp]

I noticed that when i run the app, sometimes the monitor reports error logs with DrawableWrapper of some sorts.

[renaudcerrato]

I need more informations, paste the some errors reports at least. Does it works with minify disabled?

[tuanna-hsp]

In summary:

• No minify: the toggle works, but can not finish animation, like the screenshot above. This happen when being built with some PC only, for some others it works just fine (with a same source code). Mine built fine until recently.
• Build release with minify enable: No animation at all, the toggle always showed as hamburger icon.

As for the logs, i will attach when i catch them again :)

[renaudcerrato]

Did you tried to build the sample app? Does it works?

[tuanna-hsp]

I have not but i will try.

[tuanna-hsp]

This is the log

[ernestkamara]

Hello @tuanna-hsp, Are you using wrapping the FloatingSearchView in an AppBarLayout or a custom Layout in your app above? Thanks.

[tuanna-hsp]

Yes, im using it with an AppBarLayout On Mar 11, 2016 20:18, "Ernest S. Kamara" notifications@github.com wrote:

Hello @tuanna-hsp https://github.com/tuanna-hsp, Are you using wrapping the FloatingSearchView in an AppBarLayout or a custom Layout in your app above? Thanks.

— Reply to this email directly or view it on GitHub https://github.com/renaudcerrato/FloatingSearchView/issues/9#issuecomment-195359205 .

[ernestkamara]

Can you please share your layout file with me?

[tuanna-hsp]

Problem is that if im using my friend laptop to build, its fine :) fragment_home.zip

[tuanna-hsp]

By the way, im upload some recent crash reports of our app.

[ernestkamara]

So you do not recommend using this library?

[renaudcerrato]

@tuanna-hsp : sounds like a build problem on your side. PLEASE try to build the sample using gradle command line.

[tuanna-hsp]

It seems good enough, but as up now maybe the author need some fix up. Im planning to use another one first util next library version.

[renaudcerrato]

@ernestkamara : please open an issue regarding your crash report(s).

[tuanna-hsp]

@renaudcerrato I built release using commandline, with obfuscating, and the toggle animation is gone completely. Is there any proguard rule?

[ernestkamara]

Sounds more like ProGuard issue @tuanna-hsp.

[renaudcerrato]

Agree. ᐧ

[renaudcerrato]

@tuanna-hsp : yes, they're rules but they should already be included in the default android proguard: animations works using ObjectAnimators, so you should NOT remove set/get methods! Please disable proguard to confirm.

[tuanna-hsp]

I can't disable Proguard because this is the release version of our app. And i think im not removing anything. proguard-rules.zip

[renaudcerrato]

@tuanna-hsp : I'm just asking to disable Proguard temporarily for your tests. Proguard WILL remove any "apparently" unused methods as a default. See http://stackoverflow.com/questions/11640977/how-to-use-android-propertyvaluesholder-with-proguard

[tuanna-hsp]

• No Proguard, no 'minifyEnable true' : Animation works but can't finish, like the first image in this issue. This depends on which PC the app being built.
• With Proguard, 'minifyEnable false' : No animation.

[tuanna-hsp]

And you should provide users with Proguard rule concerning the working of your library, because you know your library than us. I will try to investigate the problem when i have time :x

[renaudcerrato]

If you're using my ToggleDrawable, the rules should already be included in your build.

Something is probably going wrong in your build env?

[tuanna-hsp]

Ok, i will check again sometime :)

[danielto]

Hi, I have the same problem. When using "minifyEnabled true" there is no animation for the DrawerArrowDrawable.

I am setting the drawer icon like this: searchView.setIcon(new DrawerArrowDrawable(this));

After adding this rule to proguard, the animation works when focusing FloatingSearchView: -keep public class android.support.v7.graphics.** { *; }

But still does not work when navigation drawer is opening. But as the same behavior is in Google Play app, I suppose it it OK.

[renaudcerrato]

@danndi :

-keepclassmembers class * extends com.mypopsy.drawable.ToggleDrawable {
    void setProgress(float);
    float getProgress();
}