search

renaudcerrato / appengine-maven-repository

Free Private Maven repositories hosted on Google App-Engine, backed by Google Cloud Storage and deployed in less than 5 minutes.
https://medium.com/@renaudcerrato/free-private-maven-repositories-on-google-app-engine-in-5-minutes-a55b3388e1fd
215 stars 53 forks source link

content type not returned properly for xml files #30

Open jefimm opened 4 years ago

jefimm commented 4 years ago

The https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L104 does not work properly for the .xml files as the GCP does not set the content type for the XML and the .xml files are returned as 'application/octet-stream' This causes issue with some tools that rely on the content type

renaudcerrato commented 3 years ago

Mmmm... It sounds like your application is not setting the Content-Type header : the mime is taken from it. Can you check ?

https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L135

jefimm commented 3 years ago

might be, we are using https://leiningen.org

renaudcerrato commented 3 years ago

I'd suggest to report a bug to that tool, but we may also add some basic mime-type detection based on file extension. PR are still welcome ;)