Feedback on script arsenal

deadeert commented 3 years ago

Hello guys,

I tried your tool on couple of equipments. I have to say it works pretty well. As feedback:

for the nmap tool, to clarify the use, may be add switch arguments recv_canid and send_canid.
for the nmap tool, a switch can be added to indicate if session or service should be scanned.
for the nmap tool, while indicating discovered service, return code information (bad session, wrong format) could be added. ex: [Thread 98192 - 1609242551.062]scan.services discovered 22 Read Data By Identifier : wrongFormat [Thread 98192 - 1609242551.063]scan.services discovered 2e Write Data By Identifier: wrongSession.

I think it will help using your tool, especially for non advanced users.

Having scripts to perform readDID / readDTC / writeDID / openSession / ... will help them al lot too. I don't know if the format is standardized or if it change according to the supplier.

thanks for having release such a tool, really handy.

deadeert commented 3 years ago

I can do a PR for the first three points. But have no more access to UDS ISO so cannot implement properly the other requested features.

deadeert commented 3 years ago

Did a PR for the main topic. https://github.com/renault/cananalyze/pull/4

eledisez commented 3 years ago

Hi,

sorry for the late response.

Thanks for the feed-back, it's always a great pleasure and it's good to hear that the tool is useful.

Your PR actually improve the usage, thanks ! We will see to integrate it quickly.

I will check what we have about readDID / readDTC / writeDID ... it seems to me that these are commands are standards.

Erwan.

deadeert commented 3 years ago

Hi there, no problem, it is a very small PR, not a big deal. Let me know if I can help for the DID stuff..

renault / cananalyze

Feedback on script arsenal #3