renber / SeafClient

Seafile web api implementation for C# as .NET Standard library
MIT License
26 stars 18 forks source link

Delete File command cannot be executed #15

Closed cniccolo closed 4 years ago

cniccolo commented 4 years ago

According to https://download.seafile.com/published/web-api/v2.1/file.md the "Delete File" command needs to be of the form /api2/repos/{repo-id}/file/?p=/foo and not /api2/repos/{repo-id}/dir/?p=/foo

renber commented 4 years ago

Thank you for your contribution. You are correct, the API Path was wrong (both in API v2 and v2.1). I approve the changes regarding "too modern" language features if it enables compilation on more systems. Which .NET version do you need to target? Would a .NET Core version of the library be a feasable option for you instead?

cniccolo commented 4 years ago

Dear René

Don't worry about the too modern commit. It is only because we are still using an old version von Visual Studio for this particular project. Go for the .Net Version since that is way to go longterm.

From: René Bergelt notifications@github.com Sent: Dienstag, 7. April 2020 10:28 To: renber/SeafClient SeafClient@noreply.github.com Cc: Trebeco GmbH - Niccolo Camponovo niccolo.camponovo@trebeco.ch; Author author@noreply.github.com Subject: Re: [renber/SeafClient] Delete File command cannot be executed (#15)

Thank you for your contribution. You are correct, the API Path was wrong (both in API v2 and v2.1). I approve the changes regarding "too modern" language features if it enables compilation on more systems. Which .NET version do you need to target? Would a .NET Core version of the library be a feasable option for you instead?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/renber/SeafClient/pull/15#issuecomment-610251583, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMAV26SB4S745NVQ252TT3RLLP2ZANCNFSM4L2UONJA.