search

rench / homebridge-smarthome

this is a homebridge plugin for mijia eco-chain but also a management webapp provide web and restapi to manage your mijia eco-chain,you can control and monitor your accessory via apple's homekit or the webapp
MIT License
39 stars 6 forks source link

Add setting to pre-define name for each kit devices & fix some bugs #12

Closed chilinh closed 6 years ago

rench commented 6 years ago

@chilinh
Thank for your pr !

  1. I think custom names should not have a prefix? Just like some Chinese prefix? What do you think?
  2. Some use double quotes, some use single quotes, because of your editor problem?
chilinh commented 6 years ago

@rench

  1. I add the prefix for my purpose, but I think for all others's purpose, prefix name should be added to accessory that does not have any human readable name except sid. We can make it configurable through config.json. If we agree with this solution, I can make a commit to implement it.
  2. Sorry about coding style, I'm not set it up for this project, sorry 😄
rench commented 6 years ago

@chilinh

First of all, I strongly agree with the device custom name, but only to the custom name, I do not think the name prefix, for example: Contact xxx, Humi xxx, Switch xxx, we only need to retain xxx for display in the homekit. Because users in other languages do not necessarily recognize these prefix words, such as: Contact, Humi, Switch.

By the way, have you tested the updated yeelight plugin?