render-se / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Clang-tidy Action Version #6

Closed jrn90 closed 2 years ago

jrn90 commented 2 years ago

PX4 is using clang-tidy 6.0 for static analysis for their GitHub actions. It is 11 versions behind the latest version of clang-tidy 13.0. However, the release time difference between 6.0 and 13.0 is only two years. Still, we should figure out why they are using 6.0 instead of keeping upstream with the latest versions.

jrn90 commented 2 years ago

No response from Daniel on Slack, will follow up with email to try different communication medium.

jrn90 commented 2 years ago

Daniel Reply on Slack:

  • the checks are locked down so that they cause the build to fail
  • so that we can ratchet it up over time
  • between versions there are new things introduced and new things found, etc
  • periodically it should be bumped, then corresponding px4 updated (violations fixed or explicitly ignored)

I think this has just been put on the back burner for more pressing px4 issues. Just documenting the response if we are asked down the line.