Closed spikebrehm closed 10 years ago
@lo1tuma thoughts?
LGTM, but we need to publish rendr-handlebars 0.2.0 on npm first so the build doesn’t fail on travis.
Sorry for accidentally closing this PR, I wanted to close the comment form not the PR.
Hmm, even with publishing rendr-handlebars@0.2.0, there's still an error with its peerDependency reliance on rendr@>=0.5.0, because 0.5.0 isn't published yet -- chicken and the egg.
$ npm install
npm WARN package.json backbone@1.0.0 No repository field.
npm http GET https://registry.nodejitsu.com/rendr-handlebars/0.2.0
npm http 304 https://registry.nodejitsu.com/rendr-handlebars/0.2.0
npm http GET https://registry.nodejitsu.com/handlebars/1.3.0
npm http 304 https://registry.nodejitsu.com/handlebars/1.3.0
npm http GET https://registry.nodejitsu.com/optimist
npm http GET https://registry.nodejitsu.com/uglify-js
npm http 304 https://registry.nodejitsu.com/uglify-js
npm http 304 https://registry.nodejitsu.com/optimist
npm http GET https://registry.nodejitsu.com/wordwrap
npm http GET https://registry.nodejitsu.com/source-map
npm http 304 https://registry.nodejitsu.com/wordwrap
npm http 304 https://registry.nodejitsu.com/source-map
npm http 304 https://registry.nodejitsu.com/source-map
npm http GET https://registry.nodejitsu.com/amdefine
npm http 304 https://registry.nodejitsu.com/amdefine
npm http GET https://registry.nodejitsu.com/rendr
npm http 200 https://registry.nodejitsu.com/rendr
npm ERR! notarget No compatible version found: rendr@'>=0.5.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.1.0","0.1.1","0.2.0","0.2.1","0.2.2","0.2.3","0.2.4","0.3.0","0.3.1","0.3.2","0.3.3","0.3.4","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4-rc.1","0.4.4-rc.2","0.4.4-rc.3","0.4.4","0.4.5-rc.1","0.4.5-rc.2","0.4.5-rc.3","0.4.5-rc.4","0.4.5-rc.5","0.4.5-rc.7","0.4.5","0.4.6-rc.1","0.4.6","0.4.7-rc.1","0.4.7-rc.2","0.4.7-rc.3","0.4.7-rc.4","0.4.7","0.4.8-alpha04","0.4.8-1","0.4.7-1","0.3.5","0.4.8-2","0.4.8-3","0.4.8-4","0.5.0-alpha01","0.4.8-5","0.4.8-6","0.3.6","0.4.9","0.4.10","0.3.7","0.5.0-alpha02","0.5.0-alpha03","0.5.0-alpha04","0.5.0-alpha05","0.5.0-alpha06","0.5.0-alpha07","0.5.0-alpha08","0.4.8-alpha.1","0.4.8-alpha.2","0.4.8-alpha.3","0.5.0-alpha09","0.5.0-rc1","0.5.0-rc2"]
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! System Darwin 13.0.0
npm ERR! command "/usr/local/Cellar/node/0.10.22/bin/node" "/usr/local/bin/npm" "install"
npm ERR! cwd /Users/spike/code/rendr
npm ERR! node -v v0.10.22
npm ERR! npm -v 1.3.14
npm ERR! code ETARGET
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /Users/spike/code/rendr/npm-debug.log
npm ERR! not ok code 0
I'll just merge and publish.
There is still no 0.5.0 on npm.
Oops, I could have sworn...
Published now
On Wednesday, February 26, 2014, Mathias Schreck notifications@github.com wrote:
There is still no 0.5.0 on npm.
Reply to this email directly or view it on GitHubhttps://github.com/rendrjs/rendr/pull/331#issuecomment-36136628 .
Spike Brehm Software Engineer www.airbnb.com
San Francisco, CA, USA C: (602) 828-2358 See how Airbnb works https://www.airbnb.com/info/how_it_works
@spikebrehm now it seems rendr-handelbars 0.2.0 is missing ;)
Pushed. Strange....
Still don't see it - does it need time to sync or something?
Hmm, this must be because I've been pointing to registry.nodejitsu.com
instead of registry.npmjs.org
. The Nodejitsu guys assured me that
there's 2-way replication between the two, but if there is, there seems to
be a long delay.
I've just explicitly published to registry.npmjs.org - you should see it now
thanks I see it now :see_no_evil:
Works now, thx @spikebrehm :beers:
BTW: git tags for the new versions are still missing.
Oh yes, forgot about the tags. Thanks! Should create a script to automate this.
Woo! Let's release this thing.