Added in clear methods to model and collection stores

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.

MIT License

4.09k stars 312 forks source link

Added in clear methods to model and collection stores #383

Closed crwang closed 9 years ago

crwang commented 10 years ago

Added in some simple methods to help with clearing items in the model/collection store.

saponifi3d commented 10 years ago

@crwang - Can you please add some tests for this? Can't wait to merge this!

crwang commented 10 years ago

Will do!

crwang commented 10 years ago

I added a few tests for this.

coveralls commented 10 years ago

Coverage decreased (-0.04%) when pulling d8d2f2a7084b052fb07dce13c437279c92320340 on crwang:master into ad38fe24926964519f53e9b46b16d44437f3a6f6 on rendrjs:master.

coveralls commented 9 years ago

Coverage decreased (-0.03%) when pulling 313205befdbc31f2553a147913c1c3018fabfacd on crwang:master into 7939fc9ef9f1348e533635b51495277afd7f48b7 on rendrjs:master.

coveralls commented 9 years ago

Coverage decreased (-0.03%) when pulling d1930fb737fdd01a3aa50a537131f4e966ab597e on crwang:master into 7939fc9ef9f1348e533635b51495277afd7f48b7 on rendrjs:master.

saponifi3d commented 9 years ago

Looks awesome - but i think i broke the big green button with some conflicts. can you just merge master into this? :dart:

coveralls commented 9 years ago

Coverage decreased (-0.03%) when pulling f687fe0615ce3d72a0580d5dcd45fccaac072637 on crwang:master into ceffdb2322322eb7b2da9c766727e0a943d3b83c on rendrjs:master.

crwang commented 9 years ago

Cool, I re-merged and resolved a couple conflicts in the tests.

crwang commented 9 years ago

Cool, I'll look at it in the next day or two. Have a bunch of other things going on, but I do want to get this merged in so that it's not outstanding.

saponifi3d commented 9 years ago

Okay - i can also merge this, as that's the only thing i wasn't sure about, and make the fix myself if you're too busy :)

Thanks so much for all the work on this - i'm pretty stoked to get this merged myself.

crwang commented 9 years ago

I'll take a look in the next few hours. It should be pretty fast. Thanks!

coveralls commented 9 years ago

Coverage increased (+0.41%) when pulling ca42ebd483cc79973a94e0501b2db6677bb0e6d7 on crwang:master into ceffdb2322322eb7b2da9c766727e0a943d3b83c on rendrjs:master.

crwang commented 9 years ago

@saponifi3d I added in the functionality you mentioned. I also took out a return from the loop that you suggested since actually the returns don't really make sense. I was following the existing convention when I added the returns, but all the returns are undefined at the moment.

saponifi3d commented 9 years ago

Works like a dream! thanks for all the work on this!