Minor Fixes - Found while writing code documentation

saponifi3d commented 9 years ago

A bunch of small fixes that I found while going through and writing documentation, I'm cutting this PR before the documentation is done in the idea that I'll start developing a bit more correctly and cut a branch per fix.

Some fixes include:

initialize object attributes with undefined if they're defined later. this is a V8 runtime optimization.
removed the definitions of noop in favor of using _.noop
added expireSeconds to the collection / model store so we can start taking advantage of expiring the cache
removed all the postInitialize functions since they have been deprecated
minor whitespace issues where tabbing was off
biggest change - removed the checkFresh code and all it's surrounding attributes / helper functions. This is because checkFresh current doesn't work (it created an infinite loop). This change is to favor the idea of setting an expireSeconds rather than invoking checkFresh for a specific model.

coveralls commented 9 years ago

Coverage increased (+0.72%) to 81.68% when pulling 0689479e326aef1483953a2268da20d88790ef68 on fixes-while-documenting into 1dc9e1477525561c2ad73e2cc40b99489679511b on master.

coveralls commented 9 years ago

Coverage increased (+0.72%) to 81.68% when pulling 57a71cb9382c74b7b8e933e35d4f5a5bf7646300 on fixes-while-documenting into 1dc9e1477525561c2ad73e2cc40b99489679511b on master.

mdimas commented 9 years ago

LGTM

spikebrehm commented 9 years ago

:+1:

rendrjs / rendr

Minor Fixes - Found while writing code documentation #432