rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 312 forks source link

make sure the fetcher creates the correct collection in the store. #441

Closed saponifi3d closed 9 years ago

saponifi3d commented 9 years ago

The fetcher was creating two collections for lazy loaded views, one without parameters and one with parameters. This fix will make sure the first collection has the correct params, so it's not creating a second instance in the store when calling the fetch function when lazy loading the view.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 81.68% when pulling d0331d7b6448b03105c7c74f3e40f4bdc7ed7974 on lazy-collection-params-undefined into 89dc0f3a7ea64c6a09ae017087b100c84e26d6ee on master.

quaelin commented 9 years ago

LGTM