Call the controller method with the right context

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.

MIT License

4.09k stars 312 forks source link

Call the controller method with the right context #450

Closed purusho closed 9 years ago

purusho commented 9 years ago

The controller was called with the wrong context.
Some variable changes
Added unit test
Unit test code cleanup

coveralls commented 9 years ago

Coverage increased (+0.18%) to 82.87% when pulling 08009598d077caf55b873ec515f485d91ecb3c30 on purusho:master into 36b792340ff8ce4d7d5a6ec2e433406dfa835e17 on rendrjs:master.

purusho commented 9 years ago

Any update on merging this PR ?

alexindigo commented 9 years ago

@rendrjs/maintainers Is there anything missing from this PR that prevents it from merging? We'd like to go ahead with our changes. Thank you.

saponifi3d commented 9 years ago

:+1: sorry didn't see this PR.

saponifi3d commented 9 years ago

@alexindigo @purusho fyi - i just released version 1.0.2 which includes these changes (and the other PRs you've made) :dancers: thanks for all the work on it!

alexindigo commented 9 years ago

Thank you.