Revert "Pull router module name into variable so browserify doesn't follow it"

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.

MIT License

4.09k stars 312 forks source link

Revert "Pull router module name into variable so browserify doesn't follow it" #455

Closed saponifi3d closed 9 years ago

saponifi3d commented 9 years ago

@purusho @alexindigo

This seeeemmmss like the conflicting piece? Let me know if i'm wrong (sorry, having a hard time thinking right now)

purusho commented 9 years ago

I think you have to revert this commit : https://github.com/rendrjs/rendr/commit/cf3b47bfff8e89c5a73cee37e5af9436a55fb22f

saponifi3d commented 9 years ago

Cool, wasn't sure if you guys didn't like the dynamic style require or the placement of the require for require.js - i'm not quite sure how i follow that it's breaking in one place vs the other, in my mind it's still loading that on the client and using require to get the client-router.

if you have a minute to go into a bit of a deep explaination for me that'd be super helpful to avoid this stuff later. If not, i'll try to read up on it when i'm less swamped.

alexindigo commented 9 years ago

Hey, we're too at the team outing at the moment, so will be able to continue (thinking) later tonight. :)

-- A.I.

On Thu, Mar 26, 2015 at 4:24 PM -0700, "Josh Callender" notifications@github.com wrote:

@purusho @alexindigo

This seeeemmmss like the conflicting piece? Let me know if i'm wrong (sorry, having a hard time thinking right now)

You can view, comment on, or merge this pull request online at:

https://github.com/rendrjs/rendr/pull/455

Commit Summary

Revert "Pull router module name into variable so browserify doesn't follow it"

File Changes

M
shared/app.js
(5)

Patch Links:

https://github.com/rendrjs/rendr/pull/455.patch https://github.com/rendrjs/rendr/pull/455.diff

— Reply to this email directly or view it on GitHub.

coveralls commented 9 years ago

Coverage remained the same at 82.89% when pulling 8043f900d51fede9cbc25e59cb78c10a2729eb7e on hotfix-amd into a450430844e970ff37ab0d35dd9004f9fda59613 on master.

coveralls commented 9 years ago

Coverage remained the same at 82.89% when pulling c61c65564bcd7d26cdbb1e7c12111a5ad355f052 on hotfix-amd into a450430844e970ff37ab0d35dd9004f9fda59613 on master.

coveralls commented 9 years ago

Coverage remained the same at 82.89% when pulling c61c65564bcd7d26cdbb1e7c12111a5ad355f052 on hotfix-amd into a450430844e970ff37ab0d35dd9004f9fda59613 on master.