search

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 312 forks source link

[RFC] Fix require #456

Closed purusho closed 9 years ago

purusho commented 9 years ago

I think this should fix the require issue and still keep the original functionality of injecting an instance of ClientRouter

alexindigo commented 9 years ago

As I understood from the original (breaking) PR, that idea is to load (bundle) default router only when custom router doesn't exists. By hiding default router require from browserify. @saponifi3d can you confirm that?

So we need to support that and AMD case. Although I don't see how it would work for default router with browserify, since it won't be bundled and there would be no custom router either.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.14%) to 82.76% when pulling 70c80ba936dc06cb0ce6ec64d76dda32849c3c12 on purusho:master into a450430844e970ff37ab0d35dd9004f9fda59613 on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.14%) to 82.76% when pulling 70c80ba936dc06cb0ce6ec64d76dda32849c3c12 on purusho:master into a450430844e970ff37ab0d35dd9004f9fda59613 on rendrjs:master.

saponifi3d commented 9 years ago

@alexindigo yeah exactly, sorry i haven't spent much time using require js :( i'm poking around to see if i can't make a fix to make all the parties happy since @purusho updated the require example i have a testbed that i can play with :dancer: (Thanks for again for that update!)