rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 312 forks source link

Fix the case of some views still rendered twice on the client #463

Closed ingiulio closed 9 years ago

ingiulio commented 9 years ago

See #461

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.32%) to 84.08% when pulling a9318c37872c0929df345a921be974f81f3850af on ingiulio:master into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.32%) to 84.08% when pulling 4306306a902257980484d69c55dfb38646331111 on ingiulio:master into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.32%) to 84.08% when pulling 2f4440ba2c33e182fe149c49986de475b2240b29 on ingiulio:master into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.32%) to 84.08% when pulling 2f4440ba2c33e182fe149c49986de475b2240b29 on ingiulio:master into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

bigethan commented 9 years ago

:+1:

purusho commented 9 years ago

:+1:

bigethan commented 9 years ago

@saponifi3d any thoughts on this PR? Have you run into this issue as well?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.32%) to 84.08% when pulling 729eaac0e42455a3708ff7a7edba03caadf90f63 on ingiulio:master into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

alexindigo commented 9 years ago

@rendrjs/maintainers Is there anything else we need to do to land this PR? Thank you.

saponifi3d commented 9 years ago

Looks good to me :dancers:

ingiulio commented 9 years ago

thank you @saponifi3d!