search

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 312 forks source link

allow template finder option to be passed in within template adapter initialization #464

Closed ingiulio closed 9 years ago

ingiulio commented 9 years ago

Since https://github.com/rendrjs/rendr-handlebars/pull/51, rendr-handlebars allows a custom templateFinder as an option. These changes allow to easily pass that in from the Rendr side, breaking down a little bit the App constructor into smaller pieces, allowing for easy overriding.

Thoughts?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.04%) to 82.8% when pulling eb3917faacfd27147aaf3b29711ebb5127e6396c on ingiulio:allowTemplateFinderOptionForTemplateAdapter into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

purusho commented 9 years ago

:+1:

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.43%) to 84.18% when pulling 204f6bb4fa60ffac914101a655ac95e66f2c4fb0 on ingiulio:allowTemplateFinderOptionForTemplateAdapter into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.43%) to 84.18% when pulling 204f6bb4fa60ffac914101a655ac95e66f2c4fb0 on ingiulio:allowTemplateFinderOptionForTemplateAdapter into 5532a66de86bd64c20944276eccb5c87a59f902c on rendrjs:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.06%) to 84.22% when pulling f62bb677b06d1e4614ce305d265be2fa1d50714e on ingiulio:allowTemplateFinderOptionForTemplateAdapter into d935185fccc898edccccc08dba433ab24a700e46 on rendrjs:master.

saponifi3d commented 9 years ago

@ingiulio you rock! thanks for all the contributions - this looks great!