search

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 313 forks source link

upgrade backbone to 1.2.1 #481

Closed saponifi3d closed 9 years ago

saponifi3d commented 9 years ago

Update to all the niceness that is Backbone 1.2.1 ... like the update event!!! :dancer:

jmerrifield commented 9 years ago

:+1:

bigethan commented 9 years ago

nice!

saponifi3d commented 9 years ago

@bigethan right?! i'm about to release 1.1.0 w/ that update and the emulateHTTP changes. this is a breaking change if you have an older version of underscore or lodash being required instead of underscore. (lodash 2.4.1 doesn't have _.matches, which is now in Backbone... found that out the hard way).

pjanuario commented 9 years ago

Nice!! But it sucks that lodash doesnt have that, since it's lighter than underscore.

saponifi3d commented 9 years ago

Pedro, latest version of lodash does have it, we are on v 2.4.0 which doesn't (latest is 3.9?) Sorry for the confusion!

pjanuario commented 9 years ago

@saponifi3d Thanks! Are you using lodash or underscore in production with rendr? Any issue with using lodash? It's on my plans to change that dependency. Is something special needed for that?

saponifi3d commented 9 years ago

@pjanuario no issues with lodash until now.. we have other issues that aren't allowing us to upgrade to latest of lodash. (Generally, haven't had time to go through and make sure that it will work correctly in 3.x since it's no longer backwards compatible).

We are using browserify to shim lodash everywhere that has require('underscore') to make sure we only deliver lodash to the client as well.. We've actually been doing this since day one of Rendr @ change.

pjanuario commented 9 years ago

:+1: