rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.

MIT License

4.09k stars 312 forks source link

12 tests failing #487

Closed ErikLarsson82 closed 9 years ago

ErikLarsson82 commented 9 years ago

Hi, I cloned the repo from 1.1.0 (hash 5ee8b4a).

mocha test/*

180 passing (797ms) 12 failing

Am I missing something or is the repo in the state that it's acceptable that some tests are failing? Im doing a pull request and hope to add some tests, can I simply ignore the one currently failing?

Thanks!

pjanuario commented 9 years ago

The build seems to be green on that tag: https://travis-ci.org/rendrjs/rendr/builds/66471320

ErikLarsson82 commented 9 years ago

I ran this instead (found in package.json)

mocha -R spec ./test --recursive

... and now i got 333 passed and none failing. Thank you for your help!

crwang commented 9 years ago

@ErikLarsson82 just a side note, you should be able to just run npm test as is specified in the package.json instead of explicitly running mocha. :)

ErikLarsson82 commented 9 years ago

@crwang I had the feeling that I missed something simple like that. Noted! Thanks :+1: