Cleaned up unused leftovers. Made it more server friendly.

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.

MIT License

4.09k stars 312 forks source link

Cleaned up unused leftovers. Made it more server friendly. #499

Closed alexindigo closed 8 years ago

alexindigo commented 8 years ago

Made client/router.js to require jquery in the same way as client/app_view.js does it, in a server-sidesafe way. Removed unused requireAMD variable.

alexindigo commented 8 years ago

@saponifi3d hey, before you cut new version, can you squeeze another PR there? It will help us with server-side instrumentation a lot. Thanks. PS. Let me know if I can in of help in any way.

saponifi3d commented 8 years ago

:+1: lgtm, can you add a simple test around this?

alexindigo commented 8 years ago

@saponifi3d I could, just haven't came up with a test use case. I mean if you require that file on the server and you don't have jquery in your node_modules it would throw. Testing for that would be cumbersome. So I see it more like making client/router.js and client/app_view.js on the same page.