search

rendrjs / rendr

Render your Backbone.js apps on the client and the server, using Node.js.
MIT License
4.09k stars 313 forks source link

Attach views back in series instead of async #506

Closed purusho closed 8 years ago

purusho commented 8 years ago

When using rendr with requirejs in AMD mode the child views are attached with null as parent on the first render. Because we are waiting for the module to be loaded . This change is to forcefully attach the views in series.

alexindigo commented 8 years ago

:+1:

alexindigo commented 8 years ago

@rendrjs/maintainers Can you take a look please? AMD gods will appreciate it :)

ingiulio commented 8 years ago

:+1:

saponifi3d commented 8 years ago

Seems okay, @jmerrifield might want to try it out with browserify to verify it doesn't break that one too :) yay amd vs commonjs.

alexindigo commented 8 years ago

@saponifi3d Sorry, I got carried away with work things and lagging behind on testing app. (Looking forward for the holidays). :)

saponifi3d commented 8 years ago

No worries. I haven't had time to get to it yet either. :'(

alexindigo commented 8 years ago

@jmerrifield Any news on browserify front? :) Thanks.

jmerrifield commented 8 years ago

Haven't had a chance to check this yet, and won't be back at work until Monday to do so. I think this change will be totally fine though, probably no need to wait on me :)