search

renebigot / XlsxReaderWriter

XlsxReaderWriter is an Objective-C library for iPhone / iPad and Mac. It parses and writes MS Excel XLSX files.
MIT License
437 stars 121 forks source link

fixed broken XMLDictionary.h import #44

Open mheicke opened 8 years ago

mheicke commented 8 years ago

fix for broken PR: https://github.com/renebigot/XlsxReaderWriter/pull/36

mheicke commented 8 years ago

not sure who quick how quick @dphov will respond, so I just fixed it by myself (since it's only a couple of changed imports)

DannyEspina commented 4 years ago

Hey this might be super late but I found an alternate solution to this problem. Adding XMLDictionary/XMLDictionary.h causes an Include of non-modular header inside framework module error when you archive the project.

I solve this by adding XMLDictionary.h to the public headers of XlsxReaderWriter in Build Phases and leaving import "XMLDictionary.h" alone. This solves this issue and the non-modular header issue.

I hope this helps someone.

my question with my answer on stack overflow: https://stackoverflow.com/a/59492076/3749869

charlymr commented 4 years ago

I fork the repo and support Framework, and much mor if you are interested. FYI. XMLDictionary has been abandoned, so I removed the dependency and integrated it directly in the project.

https://github.com/charlymr/XlsxReaderWriter