search

reneeb / Mojolicious-Plugin-AdditionalValidationChecks

Add some common checks for field validation in Mojolicious
3 stars 4 forks source link

Phone check was too strict. Fixed it. #2

Closed fheyer closed 8 years ago

fheyer commented 8 years ago

Hello,

the phone check didn't accept some perfectly valid phone numbers. First problem was that no zeros in country codes and area codes were accepted. For country codes look at https://en.wikipedia.org/wiki/List_of_country_calling_codes In germany we have an area code '05102' and many others with zeros in it. So i added breaking tests and fixed the code. During work i discovered other issues which where easily fixable. I put it all in separate commits.

Thanks! Flo

reneeb commented 8 years ago

Thanks! This looks awesome... I will release a new version in a few minutes...

fheyer commented 8 years ago

Great! Thanks for the super quick response!