Test suite fails if HARNESS_TIMER is set

[eserte]

If HARNESS_TIMER is set, or the user has a ~/.proverc file with --timer in it, then the test suite fails. Sample report: http://www.cpantesters.org/cpan/report/afa437e8-a0d2-11e4-acbf-aef7e0bfc7aa 0.02 and 0.03 is affected.

[eserte]

It seems that the fix is incomplete, probably ${timer} has to be put also in the line before... See http://matrix.cpantesters.org/?dist=Mojolicious-Plugin-Prove%200.05

[reneeb]

That's not the problem. It seems that the additional timing information looks different on different machines... Some have

t/test.t ..... ok 17ms
[12:12:12]
....

others have

t/test.t ..... ok  24 ms ( 0.00 usr  0.00 sys +  0.01 cusr  0.01 csys =  0.02 CPU)
[12:12:12]
....

Do you know if there's a spec what HARNESS_TIMER does?

[reneeb]

Ok, prove --timer is no problem here, as we run a new instance of prove.

[eserte]

The different output is probably due to a change in Test::Harness 3.34: https://metacpan.org/changes/distribution/Test-Harness#L7

[reneeb]

Ok, the fix should be simple: local $ENV{HARNESS_TIMER} in the plugin. Then the time info is added to the testsuite of the plugin, but when the plugin runs tests, the timer is switched off.

[reneeb]

Should be fixed now with a7fd1cb

[reneeb]

And I had to pass '--norc' to prove... But now it seems to be fixed, finally

• http://matrix.cpantesters.org/?dist=Mojolicious-Plugin-Prove%200.07
• http://mojo.perl-services.de/#Mojolicious-Plugin-Prove,4-50,5-0,5-74