search

reneeb / Perl-Critic-OTRS

A collection of Perl::Critic policies to program in the OTRS way.
6 stars 1 forks source link

Failing tests on Windows systems #3

Closed ramananbalakrishnan closed 9 years ago

ramananbalakrishnan commented 9 years ago

Hi, I am working on this distribution for my CPAN PR challenge during January.

It has been reported through http://matrix.cpantesters.org/?dist=Perl-Critic-OTRS;os=mswin32;reports=1 that this distribution fails test 09_prohibit_core_functions.t on Windows systems.

After doing some research, I noticed that the failure reported as dmake.EXE: Error code 255, while making 'test_dynamic' is also seen in a few other modules [1], [2].

The error seems to be a result of the testing conditions, rather than the distribution itself. The solution seems to be either remove conflicting perl installations [3] or just skipping this test when detecting a Win32 OS [4].

I could send in a pull request making the required change (i.e. skip on Win32) to t/09_prohibit_core_functions.t

reneeb commented 9 years ago

Hi,

thanks for investigating the issue. I had no idea what the cause could be. I would be grateful if you could send a PR where the tests are skipped on Windows.