search

reneeb / perl-Nexmo-SMS

A Perl module for Nexmo SMS API.
5 stars 7 forks source link

Please add unicode support #1

Closed jnlin closed 12 years ago

jnlin commented 12 years ago

Nexmo support unicode text SMS, and I just add this type to Nexmo::SMS.

mbeijen commented 12 years ago

Hi Renée, Jui-Nan Lin,

I don't really understand why Unicode needs to be supported by Nexmo::SMS::UnicodeMessage. All it does, when you compare it to TextMessage, is send a type => 'unicode', to the server. I'd say this can be just as easily supported from the existing TextMessage. And maybe it should set it by default?

Because UnicodeMessage will send Unicode, but what will TextMessage send? Why not use this Unicode flag by default when sending to Nexmo?

Would love to hear your feedback.

reneeb commented 12 years ago

Hi Michiel,

according to the Nexmo documentation there is a difference between text messages and unicode messages. Even though the text has to be utf-8 encoded anyway. But if you use chars outside the latin-range, you have to use unicode message.

I will ask Nexmo staff if there is any penalty if unicode flag is used by default.

jnlin commented 12 years ago

Hi,

Some destination numbers does not support type=unicode messages (for example, US numbers).

And it's fine to make type an optional parameter in Nexmo::SMS::TextMessage to support unicode messages. I will make a patch for this.