reneecontino / id-sp17-gbrwebsite

Great Barrier Reef website
https://reneecontino.github.io/id-sp17-gbrwebsite/
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

Single-Serving Wiki To-Dos

20 to-dos, 5 points each; plus 4 extra credit to-dos

Essential

Code

30 points

Design

45 points

Optimization

5 points

Test

10 points

Git

10 points

Extra Extra

20 points

jgagne commented 7 years ago

Resolve HTML issues: https://validator.w3.org/nu/?doc=https%3A%2F%2Freneecontino.github.io%2Fid-sp17-gbrwebsite%2F

Major Issue

Before

<nav>
  <details open>
    <summary><strong>Content</strong></summary>
</nav>

    <ol>
     <li><a href="index.html">Home</a></li>
     <li><a href="geology.html">Geology and geography</a></li>
     <li><a href="ecology.html">Ecology</a></li>
     <li><a href="tourism.html">Tourism</a></li>
   </ol>

Atter

<nav>
  <details open>
    <summary><strong>Content</strong></summary> 
    <ol>
     <li><a href="index.html">Home</a></li>
     <li><a href="geology.html">Geology and geography</a></li>
     <li><a href="ecology.html">Ecology</a></li>
     <li><a href="tourism.html">Tourism</a></li>
    </ol>
  </details>
</nav>

Minor Issue

Before

<p><h4>The Great Barrier…</h4></p>

Headings are headings and paragraphs are paragraphs, not both.

After

<p>The Great Barrier…</p>

jgagne commented 7 years ago

Update <title>Navigation Demo</title>, add a meta description, and reference the original source material by including <link rel="canonical" href="…"> (add url).

jgagne commented 7 years ago

Add a comps folder with included comp for reference.

jgagne commented 7 years ago

Resolve CSS issues: http://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Freneecontino.github.io%2Fid-sp17-gbrwebsite%2Fecology.html&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Slack me if you need help.