reneecontino / id-sp17-recipe

Salted Pomegranate Chocolate Fudge
https://reneecontino.github.io/id-sp17-recipe/
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

HTML & CSS Recipe To-Dos

20 to-dos, 5 points each; 5 extra credit to-dos

Essential

Code

35 points

Design

40 points

Test

15 points

Git

10 points

Extra Extra

25 points

jgagne commented 7 years ago

This is minor, but even folders should not have spaces; use a hyphen. Please change previous recipes to previous-recipes.

jgagne commented 7 years ago

A few CSS errors; see if you can resolve them: http://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Freneecontino.github.io%2Fid-sp17-recipe%2F&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

jgagne commented 7 years ago

You also have an embedded/internal CSS in your index.html. Remove <style>…</style in your head element. Your external stylesheet main.css should be doing all the heavy lifting. In short, you have double the CSS; use the external stylesheet exclusively. Create a css folder and add main.css.

jgagne commented 7 years ago

Consider how the vertical pipes work on a small screen. Maybe instead of being set vertically, they are horizontal pipes instead? Also, resolve the in-between width, between small and wide.

description-list-pipes

jgagne commented 7 years ago

I'd bold the text of your main heading Salted Pomegranate Chocolate Fudge. Also, consider keeping "Chocolate Fudge" together, don't let them wrap. Try something like this…

html

<h1>Salted Pomegranate <span class="nowrap">Chocolate Fudge</span></h1>

css

.nowrap {
  white-space: nowrap;
}