renegadexx / T4.Helper

28 stars 25 forks source link

Fix GetAllProjects() with subfolders of folders in VS2017 #18

Closed sliddington closed 3 years ago

Eagle3386 commented 4 years ago

I'm wondering how @sliddington got this built, because he removed

public static EnvDTE.Project GetProject(EnvDTE.DTE dte, string projectName)
{
    return GetAllProjects(dte).Where(p=>p.Name == projectName).First();
}

which is still utilized in, e. g. GetTemplateProjectItem and therefore fails on my machine because of this..

sliddington commented 4 years ago

@Eagle3386 This is so long ago now I don't exactly remember what it was about. I did manually enter the changes into github and my local checkout may not have been at exactly the same point in the history.

I suspect I only removed it because it was unused in my local checkout and it looks fine to leave it in as it was.

databinding-bot-zz commented 4 years ago

Maybe some interesting information for you. We have worked out a new FileManager, which can also be used in .NET Core project: https://github.com/databinding-gmbh/T4.FileManager.VisualStudio. Currently, only the documentation is on GitHub. The code will follow.

Eagle3386 commented 4 years ago

@databinding-thierryiseli Thanks for the heads-up, but what's the actual ETA for "code will follow"?

Eagle3386 commented 4 years ago

@sliddington Sorry for kinda "resurrecting" this PR. But since you're stating that you've edited it directly in GitHub, I can see what probably caused this. For reference, I've commented on the code - at least I thought so, but it ended up here. Again, sorry for any inconvenience.

sliddington commented 4 years ago

No worries. Good to see some people tidying up this project.

On Wed, 24 Jun 2020, at 3:07 AM, Martin Arndt wrote:

@sliddington https://github.com/sliddington Sorry for kinda "resurrecting" this PR. But since you're stating that you've edited it directly in GitHub, I can see what probably caused this. For reference, I've commented on the code - at least I thought so, but it ended up here. Again, sorry for any inconvenience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/renegadexx/T4.Helper/pull/18#issuecomment-648294393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEPDJ6I7LR24QUPT52JUNALRYDONDANCNFSM4EVHKWIQ.

databinding-bot-zz commented 4 years ago

@databinding-thierryiseli Thanks for the heads-up, but what's the actual ETA for "code will follow"?

The entire code is now on GitHub and includes some user story oriented SpecFlow testing: https://github.com/databinding-gmbh/T4.FileManager.VisualStudio.