search

reneoelke / Php53to54

PHP_CodeSniffer standard for compatibility checking of PHP 5.3 to 5.4 migrations.
http://foobugs.com
Other
6 stars 1 forks source link

Error for array_combine return value should be a notice/ warning #87

Open goatherd opened 11 years ago

goatherd commented 11 years ago

The change does only matter when empty arrays are passed (false previously, empty array now). In most cases that change should not have any effect and a warning should be enough.

goatherd commented 11 years ago

Message should be something like: array_combine no longer returns false if both arguments are empty. Severity may be set less than the default of 5 (since array() == false). It rather does enhance the usability, not reduce it.