search

renepickhardt / generalized-language-modeling-toolkit

Generalized Language Modeling toolkit
http://glm.rene-pickhardt.de
52 stars 17 forks source link

Singleton Classes #84

Closed lschmelzeisen closed 9 years ago

lschmelzeisen commented 9 years ago

The toolkit contains a number of singleton classes:

It should be checked which of theses classes coudl bbe refactored to non-singleton classes, in order to be better decoubled and easiert to test.

I am mainly looking at Config as the others don't really carry state, or should exist multiple times.

lschmelzeisen commented 9 years ago

Commit b00a1379347a762c94f51e818cbe0aac0df74f1d made Chunker, LengthDistributionCalculator, Merger, NGramTimesCalculator, Tagger, QueryCacheCreator. QueryRunner. Config no longer singleton.

Leaving Outpu and LoggingHelper singleton for now.